-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception list React implementation #329
base: feat/apcd-react-conversion
Are you sure you want to change the base?
Exception list React implementation #329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The edit modal for exception has differences between localhost and dev.apcd.
There is header and field list is different in dev and production. See below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM here are some ideas for styling. May be a good idea as a follow on to eventually factor out global element styles (modal, input, table, etc) so that all table listing, form fields, and modals start with the same basic layout and then have that sheet applied to main.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some styles currently being applied to the modal and listing part of the page before your style module (EditExceptionModal.module.css) https://github.com/TACC/Core-CMS-Custom/tree/main/apcd_cms/src/apps/admin_exception/static/admin_exception/css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some styles currently being applied to the modal that could be conflicting with is. https://github.com/TACC/Core-CMS-Custom/tree/main/apcd_cms/src/apps/admin_exception/static/admin_exception/css
@@ -1,65 +1,11 @@ | |||
{% extends "apcd_cms/templates/standard.html" %} | |||
{% load static %} | |||
<link rel="stylesheet" href="{% static 'apcd-cms/css/modal.css' %}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of your style modules (ViewExceptionModal.module.css in this case) may be clashing with these stylesheets here and might be why the modals don't look the same as dev/staging/prod.
Overview
Exception list React implementation
Related
WP-635
Changes
Exception list and modals conversion.
Testing
UI